Skip to content

fix(state): defer buffer mappings loading to fix localleader menu #942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
niba wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(state): defer buffer mappings loading to fix localleader menu #942

niba wants to merge 1 commit into from

Conversation

@niba
Copy link

@niba niba commented Jan 26, 2025 •
edited
Loading

Description

The ⁠which-key menu fails to appear for ⁠localleader mappings in newly created buffers. Currently, the only way to make it work is to trigger the standard ⁠leader menu first, which seems to force a state update.

It appears that ⁠which-key attempts to load buffer mappings before the ⁠localleader mappings are fully registered. Triggering the ⁠leader menu resolves this because it re-reads the mappings, at which point they are available.

This PR defers the reading of the buffer state. This ensures that all mappings are fully established before ⁠which-key attempts to index them, effectively resolving the race condition.

Related Issue(s)

@niba niba mentioned this pull request Jan 27, 2025
Closed
3 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Feb 27, 2025

This PR is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the stale This issue or PR has been inactive for a while label Feb 27, 2025
@disrupted
Copy link

disrupted commented Feb 27, 2025

This PR is stale because it has been open 30 days with no activity.

bad bot

@github-actions github-actions bot removed the stale This issue or PR has been inactive for a while label Feb 28, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 30, 2025

This PR is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the stale This issue or PR has been inactive for a while label Mar 30, 2025
@RayJameson
Copy link

RayJameson commented Mar 30, 2025

bump

@github-actions github-actions bot removed the stale This issue or PR has been inactive for a while label Mar 31, 2025
@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2025

This PR is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the stale This issue or PR has been inactive for a while label May 1, 2025
@disrupted
Copy link

disrupted commented May 1, 2025

This PR is stale because it has been open 30 days with no activity.

bad bot

@github-actions github-actions bot removed the stale This issue or PR has been inactive for a while label May 2, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2025

This PR is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the stale This issue or PR has been inactive for a while label Jun 1, 2025
@niba
Copy link
Author

niba commented Jun 1, 2025

ping

@github-actions github-actions bot removed the stale This issue or PR has been inactive for a while label Jun 2, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2025

This PR is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the stale This issue or PR has been inactive for a while label Jul 3, 2025
@niba
Copy link
Author

niba commented Jul 3, 2025

bump

@RayJameson
Copy link

RayJameson commented Jul 3, 2025

@folke I'm sorry for pinging, but do you mind looking at this PR?

@github-actions github-actions bot removed the stale This issue or PR has been inactive for a while label Jul 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2025

This PR is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the stale This issue or PR has been inactive for a while label Aug 3, 2025
@disrupted
Copy link

disrupted commented Aug 4, 2025

this is getting tiring

@github-actions github-actions bot removed the stale This issue or PR has been inactive for a while label Aug 5, 2025
@RayJameson RayJameson mentioned this pull request Aug 12, 2025
Merged
RayJameson added a commit to RayJameson/dotfiles that referenced this pull request Aug 12, 2025
@RayJameson
fix(nvim,which-key): use fork, until local leader fix is merged upstream
2506895 
folke/which-key.nvim#942
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2025

This PR is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the stale This issue or PR has been inactive for a while label Sep 5, 2025
@niba
Copy link
Author

niba commented Sep 5, 2025

bump

@github-actions github-actions bot removed the stale This issue or PR has been inactive for a while label Sep 6, 2025
@ivangeorgiew ivangeorgiew mentioned this pull request Oct 15, 2025
Closed
@frabul frabul mentioned this pull request Nov 24, 2025
Closed
4 tasks
@niba niba force-pushed the fix/localleader_popup branch from d82109f to 71d43fe Compare December 11, 2025 21:06
@github-actions github-actions bot added the size/s Small PR (<10 lines changed) label Dec 11, 2025
@niba
Copy link
Author

niba commented Dec 11, 2025

If anyone wants to use this version, you can add the following to your config:

 {
    "folke/which-key.nvim",
    url = "https://github.com/niba/which-key.nvim",
    branch = "fix/localleader_popup",
 }

@MamaTierra
Copy link

MamaTierra commented Dec 23, 2025

If anyone wants to use this version, you can add the following to your config:

 {
    "folke/which-key.nvim",
    url = "https://github.com/niba/which-key.nvim",
    branch = "fix/localleader_popup",
 }

Works for me. Waiting for the merge 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

size/s Small PR (<10 lines changed)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: which-key menu not showing up for <localleader> mappings

4 participants

@niba @disrupted @RayJameson @MamaTierra