Skip to content

fix: removes native overlay #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pandeymangg merged 1 commit into from
Feb 13, 2026
Merged

fix: removes native overlay #48

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 4 additions & 22 deletions packages/react-native/src/components/survey-web-view.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,26 +3,15 @@ import { RNConfig } from "@/lib/common/config";
import { Logger } from "@/lib/common/logger";
import { filterSurveys, getLanguageCode, getStyling } from "@/lib/common/utils";
import { SurveyStore } from "@/lib/survey/store";
import type { TOverlay } from "@/types/common";
import { type TUserState, ZJsRNWebViewOnMessageData } from "@/types/config";
import type { TSurvey, SurveyContainerProps } from "@/types/survey";
import React, { type JSX, useEffect, useMemo, useRef, useState } from "react";
import React, { type JSX, useEffect, useRef, useState } from "react";
import { KeyboardAvoidingView, Modal, View, StyleSheet } from "react-native";
import { WebView, type WebViewMessageEvent } from "react-native-webview";

const logger = Logger.getInstance();
logger.configure({ logLevel: "debug" });

const getOverlayBackgroundColor = (overlay: TOverlay): string => {
switch (overlay) {
case "dark":
return "rgba(51, 65, 85, 0.8)";
case "light":
return "rgba(148, 163, 184, 0.5)";
case "none":
return "transparent";
}
};

const surveyStore = SurveyStore.getInstance();

Expand Down Expand Up @@ -97,15 +86,6 @@ export function SurveyWebView(
setShowSurvey(true);
}, [props.survey.delay, isSurveyRunning, props.survey.name]);

const overlay = appConfig
? (props.survey.projectOverwrites?.overlay ?? appConfig.get().environment.data.project.overlay)
: "none";

const modalContainerStyle = useMemo(
() => [styles.modalContainer, { backgroundColor: getOverlayBackgroundColor(overlay) }],
[overlay]
);

if (!appConfig) {
return;
}
Expand Down Expand Up @@ -135,6 +115,8 @@ export function SurveyWebView(
const clickOutside =
props.survey.projectOverwrites?.clickOutsideClose ??
project.clickOutsideClose;
const overlay =
props.survey.projectOverwrites?.overlay ?? project.overlay;

return (
<Modal
Expand All @@ -146,7 +128,7 @@ export function SurveyWebView(
setIsSurveyRunning(false);
}}
>
<View style={modalContainerStyle}>
<View style={styles.modalContainer}>
<KeyboardAvoidingView
behavior="padding"
style={styles.keyboardAvoidingView}
Expand Down