-
Notifications
You must be signed in to change notification settings - Fork 3
feat: adds support for attribute data types #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,38 @@ | ||
| import { UpdateQueue } from "@/lib/user/update-queue"; | ||
| import { type NetworkError, type Result, okVoid } from "@/types/error"; | ||
|
|
||
| /** | ||
| * Sets attributes on the current user/contact. | ||
| * | ||
| * Attribute types are determined by the JavaScript value type: | ||
| * - String values -> string attribute | ||
| * - Number values -> number attribute | ||
| * - Date objects -> date attribute (converted to ISO string) | ||
| * - ISO 8601 date strings -> date attribute | ||
| * | ||
| * On first write to a new attribute, the type is set based on the JS value type. | ||
| * On subsequent writes, the value must match the existing attribute type. | ||
| * | ||
| * @param attributes - Key-value pairs where values can be strings, numbers, or Date objects | ||
| */ | ||
| export const setAttributes = async ( | ||
| attributes: Record<string, string> | ||
| attributes: Record<string, string | number | Date> | ||
| // eslint-disable-next-line @typescript-eslint/require-await -- we want to use promises here | ||
| ): Promise<Result<void, NetworkError>> => { | ||
| // Normalize values: convert Date to ISO string, preserve numbers as numbers | ||
| const normalizedAttributes: Record<string, string | number> = {}; | ||
| for (const [key, value] of Object.entries(attributes)) { | ||
| if (value instanceof Date) { | ||
| // Date objects become ISO strings (backend will detect as date type) | ||
| normalizedAttributes[key] = value.toISOString(); | ||
| } else { | ||
| // Preserve strings as strings, numbers as numbers | ||
| normalizedAttributes[key] = value; | ||
| } | ||
| } | ||
|
|
||
| const updateQueue = UpdateQueue.getInstance(); | ||
| await updateQueue.updateAttributes(attributes); | ||
| await updateQueue.updateAttributes(normalizedAttributes); | ||
| void updateQueue.processUpdates(); | ||
| return okVoid(); | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.