chore: upgrade dependencies for React Native 0.84#50
Conversation
|
WalkthroughThis pull request updates dependencies across the monorepo, including Expo and React ecosystem packages in the playground application, development tools in the root package configuration, and packages in the react-native workspace. Additionally, zod schema definitions for response types are modified to explicitly specify string keys for record objects, and the Vite build configuration is updated to treat the netinfo community package as an external dependency. 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
packages/react-native/src/types/response.ts (1)
3-3:⚠️ Potential issue | 🟡 MinorPre-existing:
TResponseDataallowsRecord<string, string>butZResponseDatadoes not.The TypeScript type on Line 3 includes
Record<string, string>in its union, but the Zod schema on Line 23 only validatesz.string() | z.number() | z.array(z.string()). Data containing nestedRecord<string, string>values would pass the TS type check but fail Zod validation at runtime. This predates this PR but is worth tracking.Also applies to: 23-23
🤖 Fix all issues with AI agents
In `@packages/react-native/package.json`:
- Around line 44-45: You bumped zod from 3.x to 4.x which is a breaking change
for consumers importing exported Zod schemas (e.g., ZResponseData,
ZResponseTtc); update package.json to reflect a breaking release (bump the
package version to 3.0.0 or the next major), and add zod as a peerDependency
("zod": "^4.0.0") (or at minimum keep it as a devDependency and document the
change) plus add a concise migration note in CHANGELOG/README pointing out the
Zod v3→v4 migration for consumers importing those schemas.
🧹 Nitpick comments (1)
packages/react-native/package.json (1)
58-64: Peer dependency foreslintis pinned to an exact old version.
"eslint": "8.57.0"as a peer dependency is unusually restrictive and pins consumers to ESLint 8. This appears pre-existing but worth noting — if you're upgrading everything else, consider relaxing this to">=8.0.0"or adding ESLint 9 support.



Summary
ncu -u --deepacross the workspacez.recordsignatures@react-native-community/netinfoin the library build to avoid broken bundledNativeRNCNetInfoimportsexpo export --no-bytecodeso builds do not require a localhermescbinaryVerification
pnpm buildpnpm test