fix(script): allow --verify without --broadcast, preserving console logs#13453
Open
omair445 wants to merge 1 commit intofoundry-rs:masterfrom
Open
fix(script): allow --verify without --broadcast, preserving console logs#13453omair445 wants to merge 1 commit intofoundry-rs:masterfrom
--verify without --broadcast, preserving console logs#13453omair445 wants to merge 1 commit intofoundry-rs:masterfrom
Conversation
Previously, `--verify` required `--broadcast` and was included in `should_broadcast()`, which meant passing `--verify` alone was rejected by clap. This caused confusion when developers wanted to do a dry-run with `--verify` and still see their console.log output. Remove the `requires = "broadcast"` constraint from `--verify` and exclude it from `should_broadcast()` so that `--verify` without `--broadcast` follows the normal simulation path — printing traces, return values, and console logs as expected. Fixes foundry-rs#11009
omair445
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mattsse,
onbjerg and
zerosnacks
as code owners
Author
|
Hey everyone, I am very very sorry I got stuck in work-related stuff and haven't been able to follow up on this. I am happy if anyone else can take care of this from here or if the maintainers want to push the final bits. Apologies again for the delay! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When running
forge scriptwith--verifybut without--broadcast, console.log output was suppressed. The--verifyflag had a hardrequires = "broadcast"constraint in clap, and was also included inshould_broadcast(), meaning it couldn't be used standalone for dry-run simulation.Developers debugging their scripts with
--verifyexpected to see console logs regardless of whether they were actually broadcasting.Fix
requires = "broadcast"constraint from the--verifyarg so it can be passed independentlyself.verifyfromshould_broadcast()so that--verifyalone follows the normal simulation path (traces + console logs + "SIMULATION COMPLETE" message)--verifyand--broadcastare used together, behavior is unchangedTest
Updated the existing test to verify that
--verifywithout--broadcastnow succeeds and prints console logs.Fixes #11009