Tickets on the agent-data branch, the holder is AGENT_ID, DECISIONS.md read as a stranger - #1755
Open
suleimansh wants to merge 146 commits into
Open
Tickets on the agent-data branch, the holder is AGENT_ID, DECISIONS.md read as a stranger#1755suleimansh wants to merge 146 commits into
suleimansh wants to merge 146 commits into
Conversation
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FAY65dFQcLpVB4q32YKSv9
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FAY65dFQcLpVB4q32YKSv9
…kill (packages/framework/package.json) Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FAY65dFQcLpVB4q32YKSv9
…DME.md) Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FAY65dFQcLpVB4q32YKSv9
…C.md) Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FAY65dFQcLpVB4q32YKSv9
…sets/SPEC.md) Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FAY65dFQcLpVB4q32YKSv9
…sets/update_tickets.SPEC.md) Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FAY65dFQcLpVB4q32YKSv9
…sets/update_tickets.md) Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FAY65dFQcLpVB4q32YKSv9
…kill (packages/framework/prompts/tickets_yourself.SPEC.md) Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FAY65dFQcLpVB4q32YKSv9
…kill (packages/framework/prompts/tickets_yourself.md) Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FAY65dFQcLpVB4q32YKSv9
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FAY65dFQcLpVB4q32YKSv9
…est.SPEC.md) Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FAY65dFQcLpVB4q32YKSv9
…est.ts) Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FAY65dFQcLpVB4q32YKSv9
….ts) Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FAY65dFQcLpVB4q32YKSv9
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FAY65dFQcLpVB4q32YKSv9
…kill (packages/framework/src/daemon-runtime.ts) Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FAY65dFQcLpVB4q32YKSv9
…services.SPEC.md) Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FAY65dFQcLpVB4q32YKSv9
…services.test.SPEC.md) Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FAY65dFQcLpVB4q32YKSv9
…services.test.ts) Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FAY65dFQcLpVB4q32YKSv9
…services.ts) Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FAY65dFQcLpVB4q32YKSv9
…rd-rpc/control.SPEC.md) Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FAY65dFQcLpVB4q32YKSv9
…rd-rpc/control.test.SPEC.md) Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FAY65dFQcLpVB4q32YKSv9
…rd-rpc/control.test.ts) Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FAY65dFQcLpVB4q32YKSv9
…rd-rpc/control.ts) Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FAY65dFQcLpVB4q32YKSv9
…rd-rpc/reads.ts) Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FAY65dFQcLpVB4q32YKSv9
…rd/docs.SPEC.md) Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FAY65dFQcLpVB4q32YKSv9
…rd/docs.test.SPEC.md) Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FAY65dFQcLpVB4q32YKSv9
…rd/docs.test.ts) Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FAY65dFQcLpVB4q32YKSv9
…rd/tickets.SPEC.md) Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FAY65dFQcLpVB4q32YKSv9
…rd/tickets.ts) Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FAY65dFQcLpVB4q32YKSv9
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FAY65dFQcLpVB4q32YKSv9
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FAY65dFQcLpVB4q32YKSv9
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FAY65dFQcLpVB4q32YKSv9
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FAY65dFQcLpVB4q32YKSv9
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FAY65dFQcLpVB4q32YKSv9
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FAY65dFQcLpVB4q32YKSv9
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FAY65dFQcLpVB4q32YKSv9
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FAY65dFQcLpVB4q32YKSv9
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FAY65dFQcLpVB4q32YKSv9
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FAY65dFQcLpVB4q32YKSv9
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FAY65dFQcLpVB4q32YKSv9
…li.ts) Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FAY65dFQcLpVB4q32YKSv9
…li.test.ts) Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FAY65dFQcLpVB4q32YKSv9
…li.SPEC.md) Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FAY65dFQcLpVB4q32YKSv9
…li.test.SPEC.md) Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FAY65dFQcLpVB4q32YKSv9
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FAY65dFQcLpVB4q32YKSv9
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FAY65dFQcLpVB4q32YKSv9
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FAY65dFQcLpVB4q32YKSv9
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FAY65dFQcLpVB4q32YKSv9
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FAY65dFQcLpVB4q32YKSv9
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FAY65dFQcLpVB4q32YKSv9
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FAY65dFQcLpVB4q32YKSv9
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FAY65dFQcLpVB4q32YKSv9
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FAY65dFQcLpVB4q32YKSv9
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FAY65dFQcLpVB4q32YKSv9
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FAY65dFQcLpVB4q32YKSv9
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FAY65dFQcLpVB4q32YKSv9
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FAY65dFQcLpVB4q32YKSv9
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FAY65dFQcLpVB4q32YKSv9
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FAY65dFQcLpVB4q32YKSv9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reading
packages/agent-data/DECISIONS.mdas a stranger next to the code found three lines the code did not do yet — they described the branch after the planned rename. This PR makes the code do them, and fixes the rest of what the read found.The code now does what the file says
agent-databranch, checked out at.branches/agent-data. Theticketsbranch is gone from the code;@gemstack/skill-ticketsno longer names a branch of its own and importsDATA_BRANCHlike everyone else.AGENT_IDfrom the environment when the process that started the agent set it (the daemon sets it), else the current branch. The tickets skill no longer reads the agent id off the.branches/agent-<id>folder name, so it imports nothing from@gemstack/skill-branches— the last skill-to-skill import..branches/agent-datamatches theagent-*pattern the branches skill uses to find agent checkouts. The branches skill now treatsagent-dataas nobody's: never listed, renamed or deleted;datais refused as an agent id; an agent naming itselfdatagetsagent-data-2. The name staysagent-dataas decided.Three bugs the cold reads caught, fixed with tests:
@gemstack/agent-datatreated any remote as "has a remote" while every push namesorigin, so a repo whose only remote isupstreamgot two failed pushes instead of the stated refusal; the branches skill deleted a caller-named birth branch without checking it was anagent-*branch; a forced worktree removal logged to stdout, which is thebranchesCLI's JSON stream. One known limitation is now stated instead of hidden: a scoped package (@acme/x) an agent installs still writes into the user'snode_modules, because the dependency links go one entry deep.The text fixes (one commit per file, then fresh cold-read agents per package until a read found only wording — agent-data 12 reads, skill-branches 4, skill-tickets 5+):
agent-data/DECISIONS.md— the git terms where they exist (orphan branch, worktree,.git/info/exclude), "pushed and pulled on every change" corrected to what the code does, the two-writers bullet before the retry bullet, and four decisions the code makes that the file did not state (reads without a checkout, no remote, the git time budget, the pull also pushes a stranded commit). The tickets and branchesDECISIONS.md,SKILL.mdand SPECs follow the code changes.Not in this PR: the
agents-logsbranch stays the framework's own (the fold intoagent-datais a framework change, not a decision of any skill); the queue split intoskill-queue; publishing.Cutover, by hand, per project already running the daemon (the
ticketsbranch carries the data):then rewrite
.the-framework/LAYOUT(tickets-branch: tickets→data-branch: agent-data) as the project's own commit, since the layout gate refuses a build whose marker differs.Suites: agent-data 53, skill-branches 77, skill-tickets 58, framework 1386 node + 865 vitest, all green.
🤖 curated · Fable 5.1, effort high — the agent read the packages and wrote the changes and this text; the calls (close the gap in code rather than soften the file, keep the name
agent-data, leaveagents-logsalone) are mine.