Remove dummy DCO workflow for the merge queue - #605
Conversation
github-actions
Bot
added
the
part:template
|
Draft because it seems the upstream fix is still not working properly. See: |
The DCO GitHub App now runs on merge queue (merge_group) events, so the "DCO" required status check no longer needs to accept a status from any integration. Pin it to the DCO GitHub App (integration_id 1861) in the "Protect version branches" ruleset exports. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
The DCO GitHub App did not use to run on merge queue (merge_group) events, so a dummy workflow provided a passing "DCO" status check to satisfy the required check when merging through the queue. The DCO app now runs on merge_group events, making the dummy workflow obsolete, so drop it from the template and regenerate all affected golden fixtures. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Mirror the template and ruleset changes so existing repositories pick them up too. Add two migration steps: one removes the obsolete `.github/workflows/dco-merge-queue.yml` workflow, and one pins the "DCO" required status check in the "Protect version branches" ruleset to the DCO GitHub App (`integration_id` 1861) via the `gh` CLI. Both are idempotent and report a manual step when the change cannot be applied automatically. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
|
Ready for review. Upstream was fixed and the fix was confirmed. |
daniel-zullo-frequenz
left a comment
daniel-zullo-frequenz
left a comment
There was a problem hiding this comment.
LGTM. I've seen double backticks like in gh in many places. If our documentation renders as markdown we can just use single backsticks instead (e.g. gh). We could add a note to AGENTS in case docstrings were generated by AI
Ah, dann, yeah, AI like to use reST in docstrings, will fix. |
|
OK, they are only in the migration script, which will be gone in the next release, so since this got merged already I don't think it is worth fixing. |
Agree. But I think it's worth to add a short note to the AGENTS.md, maybe in |
3 participants
The DCO GitHub App now runs on merge queue (
merge_group) events, so the "DCO" required status check no longer needs to accept a status from any integration and we don't need to ship a dummy workflow to run in the merge queue just to satisfy the DCO check.Fixes #277 and #604.