Repository navigation
Conversation
Channels v1.13.0 has not been released yet. Use PR 595 to test the SDK against its new APIs. Raise the typing-extensions floor to 4.16.0, which channels now requires. The SDK does not declare frequenz-core directly; channels requires version 1.6.0 or later. This reference is temporary until v1.13.0 is released. Replace it with frequenz-channels >= 1.13.0, < 2 before publishing the SDK. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Import WithPrevious from its stable module, use MonotonicTimer, and call aclose() on channels. The promoted symbols are the same objects and close() delegates to aclose(), so behavior stays the same. Keep Broadcast and new_receiver(limit=...) unchanged. These APIs remain available in channels v2, and moving to BroadcastChannel would change behavior when there are no receivers. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Explain the new dependency floors and the temporary PR reference in the upgrading notes. The SDK's public API, timer behavior, and channel closing do not change, so users do not need to change their code. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
This branch will merge only after channels v1.13.0 is released. Describe the released dependency in the SDK release notes so that only the dependency commit needs updating when the release is out. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
github-actions
Bot
added
part:docs
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SDK still uses channels APIs that v2 will remove. I switched to the stable WithPrevious import, MonotonicTimer, and calls to aclose() on channels without changing the SDK's public API or behavior. Broadcast and the SDK's new_receiver(limit=...) arguments stay unchanged.
This draft waits for frequenz-channels v1.13.0. The dependency commit temporarily points at channels PR 595 for testing. Before merging, I will update that commit to require
frequenz-channels >= 1.13.0, < 2. The rest of the branch, including the release notes, already describes the released dependency. The typing-extensions floor is now 4.16.0, as channels requires.