Skip to content

Change the 'run rule' functions to special case empty arrays, in orde… #851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Numpsy wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Change the 'run rule' functions to special case empty arrays, in orde… #851

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/FSharpLint.Core/Framework/Rules.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,12 +97,12 @@ let toWarning (identifier:string) (ruleName:string) (filePath:string) (lines:str

let runAstNodeRule (rule:RuleMetadata<AstNodeRuleConfig>) (config:AstNodeRuleParams) =
rule.RuleConfig.Runner config
|> Array.map (toWarning rule.Identifier rule.Name config.FilePath config.Lines)
|> Array.mapIfNotEmpty (toWarning rule.Identifier rule.Name config.FilePath config.Lines)

let runLineRuleWithContext (rule:RuleMetadata<LineRuleConfigWithContext<'Context>>) (context:'Context) (config:LineRuleParams) =
rule.RuleConfig.Runner context config
|> Array.map (toWarning rule.Identifier rule.Name config.FilePath config.Lines)
|> Array.mapIfNotEmpty (toWarning rule.Identifier rule.Name config.FilePath config.Lines)

let runLineRule (rule:RuleMetadata<LineRuleConfig>) (config:LineRuleParams) =
rule.RuleConfig.Runner config
|> Array.map (toWarning rule.Identifier rule.Name config.FilePath config.Lines)
|> Array.mapIfNotEmpty (toWarning rule.Identifier rule.Name config.FilePath config.Lines)
8 changes: 8 additions & 0 deletions src/FSharpLint.Core/Framework/Utilities.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,14 @@ module Dictionary =

dict.Add(key, value)

module Array =

let inline mapIfNotEmpty ([<InlineIfLambda>] mapping: 'Source -> 'Dest) (array: 'Source array) =
if Array.isEmpty array
then Array.empty
else
Array.map mapping array

module ExpressionUtilities =

open System
Expand Down
Loading