Draft
Conversation
edwardchalstrey1
changed the title
edwardchalstrey1
changed the title
…e matches the filter criteria
Member
|
@rahulsavani @edwardchalstrey1 are we thinking of this as something for 16.6 or more for 16.7 once we let the catalog settle a bit and get it populated more? (And also because we've got a backlog on 16.6 to deal with so at least for my part I'm a bit limited in mindspace as to how we might want to commit to some of these design decisions.) |
5 tasks
Member
Author
@tturocy Fine with me, I'll move this back to draft for now |
Merged
* add failing test for games(include_descriptions=True) which gets used in update script * Add description field to df when selected * refactor to reduce code duplication * correctly show descriptions on catalog page * Add biblio links to all games in catalog * fix biblio links * update table row spacing * hide samples page * Add download links * generate rst table instead of CSV for Catalog of games page * Refactor table such that descriptions are nested under titles
edwardchalstrey1
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues closed by this PR
Closes #758
Closes #759
Closes #761
Description of the changes in this PR
This PR adds
GameobjectsHow to review this PR
families.pyworks as a way for adding games to the catalog. Review the change to the contributor doc which explains how to do this.games()function which allow filtering on attributes ofGameobjectsHelp me answer these questions:
one_shot_trustas an example game family in this PR, simply to demonstrate the functionality. Is there a better example we definitely want included in the catalog?Gameobject, to be looked at once the catalog is larger, if at all. Do you agree with this/ do we need it at all? If so, what is an example of a filter that would be useful when searching the catalog?