Skip to content

fix: support multiple modules in Windows image builds#47

Merged
frostebite merged 1 commit intomainfrom
fix/windows-build-unity-image-modules
May 7, 2026
Merged

fix: support multiple modules in Windows image builds#47
frostebite merged 1 commit intomainfrom
fix/windows-build-unity-image-modules

Conversation

@frostebite
Copy link
Copy Markdown
Member

Summary

This follow-up brings the merged build-unity-image command to Windows parity.

The original CLI PR #46 added the command and Ubuntu path, but the Windows Dockerfile template still only handled a single module value. This branch updates the Windows image build path to:

  • iterate over comma-separated module lists the same way the Ubuntu path does
  • use Windows-specific default hub/base images when baseOs=windows

That makes commands like the following work for the Windows image path as intended:

game-ci build-unity-image windows windows-mono,mac-mono --unity-version 2022.3.20f1

Validation

  • bun run build
  • bun test

Refs: #46, game-ci/unity-builder#771

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 7, 2026

Warning

Rate limit exceeded

@frostebite has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 31 minutes and 22 seconds before requesting another review.

To continue reviewing without waiting, purchase usage credits in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 139ef79d-7cd0-48d5-b690-7f2f175f4667

📥 Commits

Reviewing files that changed from the base of the PR and between 1771fd3 and 7f8ffbd.

⛔ Files ignored due to path filters (1)
  • dist/index.js is excluded by !**/dist/**
📒 Files selected for processing (1)
  • src/command/build-image/build-image-command.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/windows-build-unity-image-modules

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@frostebite frostebite merged commit 13a5067 into main May 7, 2026
8 checks passed
@frostebite frostebite deleted the fix/windows-build-unity-image-modules branch May 7, 2026 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant