feat(ship): preview deploy + browser verification before PR creation#685
Open
mikecourt wants to merge 6 commits intogarrytan:mainfrom
Open
feat(ship): preview deploy + browser verification before PR creation#685mikecourt wants to merge 6 commits intogarrytan:mainfrom
mikecourt wants to merge 6 commits intogarrytan:mainfrom
Conversation
Inserts a new optional step between Push and Create PR/MR that deploys a preview build, captures the preview URL, and runs a health check if configured — all without blocking the ship workflow on failure. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…al NEEDS ATTENTION banner Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds preview deployment and targeted browser verification to the
/shipworkflow, with graceful degradation when no deploy config exists.New Steps:
## Deployconfig from CLAUDE.md, runs the deploy command, captures preview URL, polls health check. Supports Vercel, Netlify, and generic CLIs. Non-blocking.Modified Steps:
preview_deployandbrowser_verifyresults for/retroDesign principle: Everything gracefully degrades. No deploy config → skip both steps. Deploy fails → warn, skip browse. No routes changed → skip browse. Browse unavailable → skip. Nothing blocks shipping.
Test Coverage
No new application code paths — this is a prompt template change (Markdown). All existing skill validation tests, E2E evals, and browse integration tests pass.
Pre-Landing Review
Pre-Landing Review: No issues found. (Markdown-only diff, no SQL/LLM/security surface.)
Adversarial Review
Claude adversarial subagent found 12 findings (9 FIXABLE, 2 INVESTIGATE, 1 design tradeoff). Key items:
teemasks deploy exit code (pipefail) — LLM handles this at runtimegrep -A 5could truncate long deploy sections — consider reading to next##/tmpfile on concurrent ships — usemktempat runtime[id]substitution undefined — LLM skips or uses known IDsAll informational. Codex unable to review (repo under
~/.claude/path restriction).Test plan
bun testpasses (skill validation + browse integration + E2E evals)bun run gen:skill-docs --dry-runconfirms template/generated file sync🤖 Generated with Claude Code