Fix: import isNullOrUndefined from ExtensionMethods instead of removed util builtin#460
Open
perbergland wants to merge 1 commit into
Open
Fix: import isNullOrUndefined from ExtensionMethods instead of removed util builtin#460perbergland wants to merge 1 commit into
perbergland wants to merge 1 commit into
Conversation
… builtin util.isNullOrUndefined was removed from Node.js (deprecated as DEP0054), so the import from "util" resolves to undefined on Node 24+ and throws TypeError when ExtendedPropertyDefinition is used. Use the library's own identically-behaving isNullOrUndefined from ExtensionMethods instead. Fixes gautamsi#459 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
ExtendedPropertyDefinition.tsimportedisNullOrUndefinedfrom Node's built-inutilmodule.util.isNullOrUndefinedwas runtime-deprecated (DEP0054) and has since been removed from Node.js — on Node 24+ the import resolves toundefinedand any use ofExtendedPropertyDefinitionthrowsTypeError: isNullOrUndefined is not a function.Change
This is the only file in the codebase still using the removed built-in. The library already exports its own
isNullOrUndefinedfromExtensionMethodswith identical semantics (obj === undefined || obj === null), and every other call site already imports it from there. This PR just redirects the import:No new dependency, no behavior change.
Verification
Fixes #459
🤖 Generated with Claude Code