feat(framework): collect business knowledge in the repo (#537)#559
Merged
Conversation
Two halves, per the issue's Implementation section. Context: every run now carries .the-framework/README.md, DECISIONS.md and KNOWLEDGE-BASE.md on the #439 `Context:` line, so the agent reads what the project already knows about itself. They ride with the built-in system prompt, not with the user's own dirs: --vanilla means no framework-authored prompt. Post-merge: a `## Business knowledge` section asks the agent to fold back what the session taught that the code cannot show. --eco-auto-maintenance dropped the whole post-merge run, which was right when that prompt was exactly the maintenance section. It no longer is, so the flag now drops just `## Maintenance` and business knowledge survives it.
Member
Author
Member
@suleimansh I don't mind AI slope e.g. (DRY issues) for the code, but for all the prompting let's always take an extra look and give it extra thoughts. Thoughful prompts, always. Zero vibe-coded half-hassed prompts, ever. Feel free to ping me for everything related to prompting. When AI will apply the changes above, let's review carefuly whether its changes related to prompting matches what I said above (zero tolerence for AI slope in prompting). |
suleimansh
added a commit
that referenced
this pull request
Jul 16, 2026
…xt (#591) (#593) Apply Rom's #559 review of the #537 business-knowledge feature: - drop README.md from the knowledge docs (the repo's own README covers the overview) - move DECISIONS.md / KNOWLEDGE-BASE.md to the repo root, not .the-framework/ - carry each doc's one-line gloss into the injected Context: too, as bullets - replace the ## Business knowledge prompt with Rom's verbatim wording Closes #591
suleimansh
added a commit
that referenced
this pull request
Jul 16, 2026
…) (#600) It fires on setReadyForMerge(), before the merge, so "post-merge" was a misnomer (Rom, #559). Renamed the concept end to end: the --post-merge flag is now --on-before-mergeable; runPostMerge / renderPostMergePrompt / PostMergeContext / POST_MERGE_PROMPT become their OnBeforeMergeable equivalents; the prompt file is on_before_mergeable_prompt.md; the drift snapshot and the dashboard preference key (postMergeQuality -> onBeforeMergeableQuality) follow. No agent-facing prompt text changed: the string "post-merge" never appeared in any prompt, only in code, comments, filenames and the flag. The dashboard's visible "Post-merge cleanup" label is left as-is pending a copy decision. Framework 541/1 skip/0 fail, drift green, framework + dashboard typecheck clean. Closes #592
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #537
Both bullets from the issue's Implementation section.
1. The docs go on the
Context:line..the-framework/README.md,DECISIONS.mdandKNOWLEDGE-BASE.mdjoin the#439context line on every run, alongside the directories the user selects. OneKNOWLEDGE_DOCSconst; a test pins the post-merge prompt against it so the two halves cannot name different files.2. The post-merge prompt asks the agent to update them. New
## Business knowledgesection:BRAINSTORMING.mdis left out, per the issue.Two calls made here
--vanilla("Disable system prompt") only the user's own--contextdirs survive. The docs are ours, and [The Framework] Remove the persona / skill / memory framing #547 rule 3 is no framework-authored prompt when it's off.--eco-auto-maintenanceno longer skips the whole post-merge run, it drops just## Maintenance. Skipping wholesale was right while the post-merge prompt was exactly the maintenance section (Post-merge prompt: add TODO entries instead of running the presets inline #556). It isn't any more, and the flag does not name business knowledge, so it must not take it along.Ran it for real
Real binary, real git repo, ~$1. A repo whose
DECISIONS.mdsaid "flat pricing, no surge" while the session's commit shipped surge pricing:DECISIONS.mdoff the context line unprompted, and caught the contradiction.KNOWLEDGE-BASE.mdthat records what the code cannot: that the1.4multiplier has no recorded derivation, thatbookedHourhas no timezone attached, and thatsameDayis caller-supplied so a client could opt out of surge. It explicitly left the surge rationale out, because that one is in a code comment.composeRunSystem4475 -> 4573 chars.Green: framework tests pass except
runCli --daemon backgrounds the dashboard, which fails identically on cleanmainhere (a daemon is already live on :4200) — pre-existing and environmental, not from this change.