fix(framework): savePreferences returns the typed error on a failed write#618
Merged
Conversation
suleimansh
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
savePreferencesadvertises a{ ok: false, error }result and returns it for the not-enabled case, but a failedstore.savethrew straight through, so the client saw a rejected RPC instead of the typed error. The write is now wrapped in try/catch, so both failure modes (not-enabled, write-failed) return{ ok: false }and the client handles them the same.Regression test added via
provideTelefuncContext(a store whose save throws ->{ ok: false, error: 'failed to save preferences' }). Changeset: patch.