fix: issues found in comprehensive tests: cache capacity, watsonx#560
Merged
jakelorocco merged 1 commit intomainfrom Feb 26, 2026
Merged
fix: issues found in comprehensive tests: cache capacity, watsonx#560jakelorocco merged 1 commit intomainfrom
jakelorocco merged 1 commit intomainfrom
Conversation
Contributor
|
The PR description has been updated. Please fill out the template for your PR to be reviewed. |
jakelorocco
force-pushed
the
jal/fix-test-issues
branch
from
b210d5f to
040bcdb
Compare
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
jakelorocco
force-pushed
the
jal/fix-test-issues
branch
from
040bcdb to
894b78f
Compare
model name, and alora training on macs
jakelorocco
force-pushed
the
jal/fix-test-issues
branch
from
894b78f to
66e6d6b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Misc PR
Type of PR
Description
Fixes issues to test. Tested that the alora training test works on both mac and linux (and correctly maps to fp16=True on linux with cuda).
Testing