docs: fixes version detection logic#561
Merged
psschwei merged 1 commit intogenerative-computing:mainfrom Feb 26, 2026
Merged
Conversation
Contributor
|
The PR description has been updated. Please fill out the template for your PR to be reviewed. |
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
jakelorocco
approved these changes
Feb 26, 2026
psschwei
approved these changes
Feb 26, 2026
ajbozarth
approved these changes
Feb 26, 2026
Merged
via the queue into
generative-computing:main
with commit Feb 26, 2026
7393095
10 of 12 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Misc PR
Type of PR
Description
The Problem:
The GitHub Action is passing --pypi-version main to the script. The
normalize_versionfunction intooling/docs-autogen/generate-ast.pyat L64-L67, only strips a leading "v" from versions but doesn't handle branch names like "main".This results in pip_install constructing
mellea==mainattooling/docs-autogen/generate-ast.pyat L171, which is invalid pip syntax. Pip expects a semver version like 0.3.0, not a git branch name.The normalize_version function doesn't validate that the version is actually a valid version number. When "main" is passed, it's passed through unchanged, creating the invalid requirement mellea==main.
The Fix:
Update normalize_version to return None for non-version strings like "main" (or any value that doesn't look like a valid version). When normalize_version returns None, pip_install already handles it correctly by installing without a version pin (i.e., latest from PyPI).
Testing
Manually tested with this snippet