Conversation
There was a problem hiding this comment.
Pull request overview
Adds a Lantern-specific semantic convention key to record the provenance of geolocation data, complementing the existing standard OTel geo.* attributes re-exported in standard.go.
Changes:
- Introduces
GeoSourceKey("geo.source") as a newattribute.Keyconstant for tracking geolocation source metadata.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| const ( | ||
| // GeoSourceKey defines how a geolocation was determined. | ||
| // - geolocation database (e.g. "maxmind") | ||
| // - client attestation (e.g. "client") |
There was a problem hiding this comment.
This new attribute key is added as its own const block without a section header comment, whereas other groups in custom.go are introduced with a category header (e.g., // Client Info, // Proxy resource attributes). Consider adding a // Geo (or similar) header above this block for consistency and easier discoverability.
Also, to render better in GoDoc, consider using a blank line before the examples list and formatting the bullets as // - ... (single space after //) rather than // - ....
| const ( | |
| // GeoSourceKey defines how a geolocation was determined. | |
| // - geolocation database (e.g. "maxmind") | |
| // - client attestation (e.g. "client") | |
| // Geo | |
| const ( | |
| // GeoSourceKey defines how a geolocation was determined. | |
| // | |
| // - geolocation database (e.g. "maxmind") | |
| // - client attestation (e.g. "client") |
Because geolocation is a best-effort practice, it's good to identify the source of geo information.