fix(errors): separate informational notes from actionable alternatives in ContextError#651
Merged
fix(errors): separate informational notes from actionable alternatives in ContextError#651
Conversation
…s in ContextError Add optional `note` parameter to ContextError for diagnostic context, rendered as a "Note:" section after the actionable "Or:" alternatives. Fixes CLI-VN where the Or: section contained non-actionable DSN info.
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Bug Fixes 🐛
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
Contributor
Codecov Results 📊✅ 134 passed | Total: 134 | Pass Rate: 100% | Execution Time: 0ms 📊 Comparison with Base Branch
✨ No test changes detected All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 1376 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 95.64% 95.64% —%
==========================================
Files 219 219 —
Lines 31540 31551 +11
Branches 0 0 —
==========================================
+ Hits 30164 30175 +11
- Misses 1376 1376 —
- Partials 0 0 —Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
noteparameter toContextErrorfor diagnostic context, rendered as a separate "Note:" section after the actionable "Or:" alternativesissue listandproject viewcommandsBefore:
After:
Fixes CLI-VN