Repository navigation
ref(people): Attribute spend to the Turn Actor - #3023
Open
sentry-junior[bot] wants to merge 1 commit into
Open
sentry-junior[bot] wants to merge 1 commit into
sentry-junior[bot] wants to merge 1 commit into
Conversation
People spend, duration, and tokens now come from each Turn's metric rows, grouped by the Actor of that Turn. Conversation counts stay on the Actor that started each Conversation. Someone who only ran Turns in other people's Conversations now appears in People. Metric rows store the Turn Actor's Identity. A migration fills old rows from the Actor of the row's Conversation, else its root. Co-Authored-By: David Cramer <23610+dcramer@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
14 screenshot changes — 14 changed · 0 added · 0 removed Review screenshots in Frameshift
Show 8 more changed screenshots
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spend now follows the Turn, not the Conversation. If Ana starts a Conversation and Ben runs a Turn in it, Ben's cost counts for Ben.
Behavior
/api/people/me/spendand its version token) read cost, duration, and tokens fromjunior_conversation_metrics. They group by the Actor of each Turn and bucket byoccurred_at.peopleTreeMetricsJoin) is gone.Write path
actor_identity_id, plus an index on (actor_identity_id,occurred_at).turn-cursor.tspass the Identity of the Turn Actor. Child Task Turns already run as the Actor that invoked them.Backfill (
0091)Stays on the root Actor: Conversation counts (conversations, active, failed, active days), the first and last seen times of people who started Conversations, and recent Conversations. Conversation detail and list costs stay per Conversation.
any-resource-event-automationsandattachment-s3-storagealso fail onmain. The automation tests that failed during the full run pass when run alone. I did not run evals.via @dcramer.
--
View Session [Sentry]