ref: use generic Docker image release pipeline#204
ref: use generic Docker image release pipeline#204aldy505 wants to merge 5 commits intogetsentry:mainfrom
Conversation
.craft.yml
Outdated
| contexts: | ||
| - 'Publish' |
There was a problem hiding this comment.
Bug: The .craft.yml configures craft to wait for a 'Publish' GitHub status check that no workflow sets, blocking releases.
Severity: CRITICAL | Confidence: 1.00
🔍 Detailed Analysis
The .craft.yml file configures statusProvider to wait for a GitHub status check named 'Publish'. However, no existing workflow in the repository sets this 'Publish' status. This will cause the craft CLI tool, invoked by action-prepare-release in release.yml, to indefinitely wait for a non-existent status, blocking the release pipeline from completing successfully.
💡 Suggested Fix
Either remove the statusProvider configuration from .craft.yml, ensure a workflow sets the 'Publish' status, or change the context name to an existing status.
🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: .craft.yml#L8-L9
Potential issue: The `.craft.yml` file configures `statusProvider` to wait for a GitHub
status check named 'Publish'. However, no existing workflow in the repository sets this
'Publish' status. This will cause the `craft` CLI tool, invoked by
`action-prepare-release` in `release.yml`, to indefinitely wait for a non-existent
status, blocking the release pipeline from completing successfully.
Did we get this right? 👍 / 👎 to inform future reviews.
Reference_id: 2703558
Swatinem
left a comment
There was a problem hiding this comment.
rubberstamping, I don’t really understand all the details here.
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Log in to GitHub Container Registry | ||
| uses: docker/login-action@v3 |
There was a problem hiding this comment.
as you have pinned all the other actions to the SHA in a different PR, might as well do that here as well :-)
Dismissing review without context
|
Let's please wait with this until we have reached a stable integration of Objectstore into Sentry. After this, we can include it in self-hosted. |
|
Craft made a breaking change, and we're changing self-hosted build pipeline |
To help with getting this to self-hosted. If this PR is merged, we won't automatically generate the release for self-hosted, the issue on the
publishrepo can be safely rejected.