feat: Add positioning: "relative|absolute" to View Hierarchy
#150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
approved these changes
Feb 3, 2026
Member
Lms24
left a comment
Lms24
left a comment
There was a problem hiding this comment.
LGTM from my end! I asked the mobile team for their input as well
antonis
approved these changes
Feb 4, 2026
philprime
reviewed
Feb 4, 2026
| * `windows`: contains all visible windows, on mobile it's typically just one or two (e.g. if a dialog is open) | ||
| * `type`: The fully qualified widget class name, this name may be obfuscated on certain platforms (e.g. Android release builds with proguard enabled) | ||
| * `children` nests all child UI widgets, which then builds up the whole UI tree | ||
| * `positioning`: indicates how the element is positioned in relation to its parent. If not supplied, defaults to platform default. |
Member
There was a problem hiding this comment.
Where do we define the platform default? Can we add a link here?
Member
There was a problem hiding this comment.
As per, getsentry/sentry#107507, relative is the default and there is a small list of platforms overriding it.
Lms24
pushed a commit
to getsentry/sentry
that referenced
this pull request
Feb 9, 2026
- Ref getsentry/rfcs#150 Currently relative/absolute positioning for View Hierarchy wireframes is always relative unless the platform matches a predefined list: https://github.com/getsentry/sentry/blob/e07092c0583191c0a85e3f70a8d918920a569870/static/app/components/events/viewHierarchy/wireframe.tsx#L51-L54 This PR allows overriding the platform defaults via the root `positioning` property in the hierarchy data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently relative/absolute positioning for View Hierarchy wireframes is always relative unless the platform matches a predefined list:
https://github.com/getsentry/sentry/blob/e07092c0583191c0a85e3f70a8d918920a569870/static/app/components/events/viewHierarchy/wireframe.tsx#L51-L54
SDKs should be able to override this without having to update this predefined list in Sentry.