Skip to content

docs(react-native): Document touch breadcrumb label fallbacks#17650

Merged
antonis merged 4 commits intomasterfrom
antonis/rn-touch-breadcrumb-label-fallbacks
May 7, 2026
Merged

docs(react-native): Document touch breadcrumb label fallbacks#17650
antonis merged 4 commits intomasterfrom
antonis/rn-touch-breadcrumb-label-fallbacks

Conversation

@antonis
Copy link
Copy Markdown
Contributor

@antonis antonis commented May 6, 2026

DESCRIBE YOUR PR

Updates React Native touch event docs to reflect that accessibilityLabel, aria-label, and testID are now automatically used as label fallbacks for touch breadcrumbs (added in getsentry/sentry-react-native#6103).

Changes:

  • touchevents.mdx: Rewrote the "Tracking Specific Components" section to correctly distinguish between the label fallback chain (sentry-label > labelName > accessibilityLabel > aria-label > testID) and the name field (Babel annotation / displayName). Updated labelName option description.
  • user-interaction-instrumentation.mdx: Updated the label identification description to mention the full fallback chain.

IS YOUR CHANGE URGENT?

  • Urgent deadline (GA date, etc.)
  • Other deadline
  • None: Not urgent, can wait up to 1 week+

⚠️ Should be merged after getsentry/sentry-react-native#6103 is released

PRE-MERGE CHECKLIST

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented May 6, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
sentry-docs Ready Ready Preview, Comment May 7, 2026 0:42am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
develop-docs Ignored Ignored Preview May 7, 2026 0:42am

Request Review

The **label** is determined by the first available value from:

1. `sentry-label` prop
2. Custom `labelName` prop (if configured on the boundary)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

m: Are 1 and 2 switched?

The diff from .../user-interaction-instrumentation.mdx suggests as much (unless I'm misreading?)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍 The list order is correct since sentry-label is checked first in the code but the user-interaction-instrumentation.mdx is misleading. I updated with a00a0dd

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@codeowner-assignment codeowner-assignment Bot requested a review from a team May 7, 2026 12:19
Copy link
Copy Markdown
Member

@0xadam-brown 0xadam-brown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see Sentrybot has chimed in. I'm guessing the current wording is being precise where the bot isn't – approving on that basis. Obviously feel free to adjust if needed 👍

The full priority list is documented in touchevents.mdx.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@codeowner-assignment codeowner-assignment Bot requested a review from a team May 7, 2026 12:28
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@antonis antonis merged commit 412ef43 into master May 7, 2026
18 checks passed
@antonis antonis deleted the antonis/rn-touch-breadcrumb-label-fallbacks branch May 7, 2026 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants