Skip to content

fix: match list markers to heading color instead of accent#17740

Merged
coolguyzone merged 5 commits into
masterfrom
fix/ol-marker-heading-color
May 12, 2026
Merged

fix: match list markers to heading color instead of accent#17740
coolguyzone merged 5 commits into
masterfrom
fix/ol-marker-heading-color

Conversation

@sentry-junior
Copy link
Copy Markdown
Contributor

@sentry-junior sentry-junior Bot commented May 12, 2026

Problem

Ordered list numbers in doc pages are styled with var(--accent) — the same purple used for links — making them appear clickable when they aren't.

Reported in [docs] User Feedback: Numbers appear clickable but are not.

Fix

Two changes to the marker: utilities on the doc page prose container in src/components/docPage/index.tsx:

  1. Color: marker:text-[var(--accent)]marker:text-[var(--darkPurple)] — matches h1/heading color
  2. Weight: adds marker:font-normal — sets font-weight: 400 to match the mockup design
  • Light mode: markers render in #1F1633 (dark purple, same as headings) at weight 400
  • Dark mode: --darkPurple is overridden to var(--foreground) via the .dark rule in globals.css, staying consistent with headings

Alternative

See also #17739 which uses --gray-12 (body text color) instead.

PR opened on behalf of @m1ch1.

Change marker color from var(--accent) to var(--darkPurple) so ordered
list numbers match h1/h2/h3 heading color instead of the link accent.

In light mode this is #1F1633 (dark purple); in dark mode it resolves
to var(--foreground) via the .dark override, staying consistent with
headings in both themes.

Alternative to #17739 (which uses --gray-12 body text color).
PR opened on behalf of @m1ch1.
@vercel
Copy link
Copy Markdown

vercel Bot commented May 12, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
develop-docs Ready Ready Preview, Comment May 12, 2026 9:33pm
sentry-docs Ready Ready Preview, Comment May 12, 2026 9:33pm

Request Review

getsentry-bot added 2 commits May 12, 2026 21:05
Adds marker:font-normal so ordered list numbers render at weight 400,
matching the mockup design alongside the --darkPurple heading color.
Switches marker:font-normal (400) to marker:font-medium (500).
Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 7f27d43. Configure here.

Comment thread src/components/docPage/index.tsx
cursoragent and others added 2 commits May 12, 2026 21:22
Align document list marker styling with the mockup by using normal marker font weight instead of medium.

Co-Authored-By: Claude <noreply@anthropic.com>

Co-authored-by: Alex Krawiec <coolguyzone@users.noreply.github.com>
className={[
'pt-6 px-6 prose dark:prose-invert max-w-full text-[var(--gray-12)] prose-a:no-underline hover:prose-a:underline',
'prose-code:font-normal prose-code:font-mono marker:text-[var(--accent)] prose-li:my-1',
'prose-code:font-normal prose-code:font-mono marker:text-[var(--darkPurple)] marker:font-medium prose-li:my-1',
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The list marker font weight is set to marker:font-medium instead of the intended marker:font-normal, contradicting the PR's goal.
Severity: LOW

Suggested Fix

Change the class marker:font-medium to marker:font-normal at src/components/docPage/index.tsx:93 to align the list marker font weight with the intended design as specified in the PR description.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: src/components/docPage/index.tsx#L93

Potential issue: The code at `src/components/docPage/index.tsx:93` applies the
`marker:font-medium` Tailwind CSS class, resulting in a font weight of 500 for list
markers. However, the pull request description and a specific commit message
(`685eb6d1`) explicitly state the intention was to use `marker:font-normal` (font weight
400) to match a design mockup. The final committed code appears to have accidentally
retained the incorrect `font-medium` class, leading to a visual inconsistency with the
intended design.

Did we get this right? 👍 / 👎 to inform future reviews.

@coolguyzone coolguyzone merged commit b7e6b9a into master May 12, 2026
21 checks passed
@coolguyzone coolguyzone deleted the fix/ol-marker-heading-color branch May 12, 2026 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants