Draft
Conversation
Contributor
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- gcdump reading ([#4265](https://github.com/getsentry/sentry-dotnet/pull/4265))If none of the above apply, you can opt out of this check by adding |
This was referenced Jun 7, 2025
Collaborator
|
Looks like you can get at some quite cool functionality via the vendored in code 👍🏻 If you wanted something quick and dirty, out of process, this might also work: That avoids the complexity of vendoring in the code. On the other hand, if we did vendor in that code above, we might avoid the dependency that we currently have on needing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What if we read the gcdump, then augment the low memory event with the top offending types
Not sure how much memory would take to do this in-memory in a process that just triggered a memory dump for being out of memory
It probably needs to be done on a separate process. Or only on restart?
Or on the server, at ingestion time. Considering the mess it would be to get this into the SDK (I had to hack a lot to get it to run) it might be better doing this as a stand alone library, and load it during ingestion time in Sentry when processing
gcdumpfiles.Required hacks on perfview too: