More PR review changes #5028
Merged
More PR review changes #5028
+12
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
### Features
- More PR review changes ([#5028](https://github.com/getsentry/sentry-java/pull/5028))If none of the above apply, you can opt out of this check by adding |
markushi
approved these changes
Jan 14, 2026
adinauer
added a commit
that referenced
this pull request
Jan 14, 2026
* Metrics Options * MetricsApi stub * Add transport types for metrics * Enable metrics by default * Format code * Add batch processor for Metrics * Wire up Metrics parts * Metrics counter basic API * Metrics Count API * Metrics Distribution API * Metrics Gauge API * Metrics Envelope item deserialization * Record client report for discarded metrics envelope item * Metrics external options * Metrics Manifest options for Android * Android Metrics batch processor and factory * Only send user attributes if sendDefaultPii is true * Remove Experimental Annotation from Metrics Options * Add unit tests for Metrics * Create SentryMetricsParameters for Metrics * Use uv for managing python version * fix * Add device and OS attributes to metrics * Add AI rules files for Metrics (and update feature flags rule) * Close and flush MetricsBatchProcessor from SentryClient * fix * Add E2E tests for Metrics * Final keyword in Metrics methods * Add Hint to Metrics * SentryMetricsParameters create shortcut for attributes map * Automatically use SentryOptions.Metrics.BeforeSendMetricCallback Spring beans * Rename sample API param, remove sleep * Create MetricsUnit constants * Format code * Metrics Options (#4980) * feat(metrics): [Trace Metrics 2] MetricsApi stub (#4981) * Metrics Options * MetricsApi stub * More PR review changes (#5028) * Some more PR review changes * Format code --------- Co-authored-by: Sentry Github Bot <[email protected]> * changelog * non nullable trace id * error log now says metric instead of log --------- Co-authored-by: Sentry Github Bot <[email protected]> Co-authored-by: lcian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps