test(node): Remove generic-pool fake unit test#21439
Merged
Merged
Conversation
The unit test stood up a fake `generic-pool` module to drive the instrumentation. Its parent-attachment case is already covered by the `genericPool` / `genericPool-v2` node-integration-tests (the acquire span is asserted nested inside the transaction), so the fake is redundant. The remaining "disabled" case only exercised generic OTel unpatch plumbing, not Sentry-specific logic, so it is dropped rather than ported. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
nicohrubec
requested review from
JPeer264,
andreiborza and
mydea
and removed request for
a team and
mydea
andreiborza
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These unit tests aren't needed: the acquire-span (parent attachment) case is already covered by the
genericPool/genericPool-v2integration tests, and the only other case is the trivial disable scenario.