test(react-router): Finalize instrumentation api e2e coverage#21468
Merged
Conversation
chargome
requested review from
a team,
nicohrubec and
s1gr1d
and removed request for
a team
s1gr1d
approved these changes
Jun 11, 2026
Comment on lines
+27
to
+31
| expect(redisSpans.every(span => span.data?.['db.system'] === 'redis')).toBe(true); | ||
| expect(redisSpans.every(span => typeof span.parent_span_id === 'string')).toBe(true); | ||
| expect(redisSpans.some(span => span.data?.['net.peer.port'] === 6379)).toBe(true); | ||
|
|
||
| const statements = redisSpans.map(span => String(span.data?.['db.statement'] ?? '').toLowerCase()); |
Member
There was a problem hiding this comment.
Out of scope for this PR but heads-up that db.statement and db.system are deprecated (also net.*): https://getsentry.github.io/sentry-conventions/attributes/db
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the remaining native-instrumentation-path e2e coverage to the
react-router-7-framework-instrumentationappcloses #21395