ref: Update to use @sentry/conventions#21489
Closed
mydea wants to merge 2 commits into
Closed
Conversation
Contributor
size-limit report 📦
|
This updates all packages except node to use sentry conventions instead of opentelemetry conventions. There should be no functional change.
mydea
force-pushed
the
feat/use-sentry-conventions
branch
from
67fb5f2 to
23cd953
Compare
Member
Author
|
Decided to instead split this into a PR per package to make it easier to review and figure out build issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates all packages except
nodeto use@sentry/conventionsfor semantic-convention attribute keys instead of@opentelemetry/semantic-conventions. There should be no functional change — the attribute keys set are identical.@sentry/conventionsis added as a devDependency and vendored into the build output (tree-shaken to only the keys used), so it does not become a runtime dependency. Where an attribute name exists in@sentry/conventionsit is imported from there; the few that don't (e.g.faas.execution,faas.id, AWS-specific keys) stay vendored locally as before.Notable details
preserveModulesRoot: 'src'was added to the rollup config of thepreserveModules: truepackages so the vendored@sentry/conventionscopy doesn't shift the emitted output layout (matching the existingaws-serverlesssetup).pathsmapping inpackages/typescript/tsconfig.jsonlets the repo'smoduleResolution: "node"type builds resolve the@sentry/conventions/attributessubpath export. Build-time only — the keys are vendored into the bundles, so it never reaches published artifacts.aws-serverless's vendoredsemconv.ts, the 21 keys that exist in@sentry/conventionsare now imported directly at their use sites; the AWS-specific / enum-value / metric consts remain vendored.packages/nodeis intentionally left on@opentelemetry/semantic-conventionsand will be handled separately.