ref(nitro): Inherit base Vitest config for vendored @sentry/conventions#21499
Closed
mydea wants to merge 1 commit into
Closed
ref(nitro): Inherit base Vitest config for vendored @sentry/conventions#21499mydea wants to merge 1 commit into
@sentry/conventions#21499mydea wants to merge 1 commit into
Conversation
…ns` loads on Node 18 `packages/nitro/vite.config.ts` overrode `test` wholesale, so it did not pick up the base config's `server.deps.inline` rule. Spread `...baseConfig.test` so nitro's tests transform the vendored `@sentry/conventions` ESM copy instead of `require()`-ing it (which fails on Node 18). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Member
Author
|
Superseded by the foundational build-infra fix #21503, which relocates vendored deps out of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packages/nitro/vite.config.tsredefinedtestwholesale, so it did not inherit the base config'sserver.deps.inlinerule. Since nitro's tests load the@sentry/node/@sentry/opentelemetrybuilds (which vendor@sentry/conventionsas ESM.js), Vitest would externalize andrequire()that ESM copy — which fails on Node 18 (norequire(esm)support).This spreads
...baseConfig.testso nitro inherits the inline rule, alongside the same shared infra changes as the other@sentry/conventionsPRs:vite/vite.config.ts— inline@sentry/conventionsin Vitest.packages/typescript/tsconfig.json— map the@sentry/conventions/attributessubpath fornodemoduleResolution type builds.Part of splitting the larger
@sentry/conventionsmigration into per-package PRs.Ref: #20982
🤖 Generated with Claude Code