fix(jsonwriter): return NULL on allocation failures#1772
Merged
Conversation
Track write failures in the jsonwriter so that `into_string` returns `NULL` instead of producing truncated output when allocations fail. Change the ops function pointers to return `int` (0 on success) so that the callers can detect failures. Add a `write_buf` wrapper matching the existing `write_char`/`write_str` helpers and update `write_json_str` to use it instead of calling the ops directly. Check the `failed` flag in `can_write_item` and `into_string_sb` to short-circuit writes and return `NULL` respectively.
mujacica
approved these changes
Jun 1, 2026
JoshuaMoelans
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Came up at:
Track write failures in the jsonwriter so that
into_stringreturnsNULLinstead of producing truncated output when allocations fail.Change the ops function pointers to return
int(0 on success) so that the callers can detect failures. Add awrite_bufwrapper matching the existingwrite_char/write_strhelpers and updatewrite_json_strto use it instead of calling the ops directly.Check the
failedflag incan_write_itemandinto_string_sbto short-circuit writes and returnNULLrespectively.