Skip to content

merge master#2026

Open
Litarnus wants to merge 3 commits into5.xfrom
merge-master
Open

merge master#2026
Litarnus wants to merge 3 commits into5.xfrom
merge-master

Conversation

@Litarnus
Copy link
Contributor

Merges the current master into 5.x

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

$resolver->setAllowedTypes('ignore_exceptions', 'string[]');
$resolver->setAllowedTypes('ignore_transactions', 'string[]');
$resolver->setAllowedTypes('trace_propagation_targets', ['null', 'string[]']);
$resolver->setAllowedTypes('strict_trace_continuation', 'bool');
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dead strict_trace_propagation option silently ignored after rename

Medium Severity

The strict_trace_propagation option is still registered with setAllowedTypes and given a default value, but its getter (isStrictTracePropagationEnabled) and setter (enableStrictTracePropagation) were renamed to isStrictTraceContinuationEnabled / enableStrictTraceContinuation which now read from strict_trace_continuation. Any user passing 'strict_trace_propagation' => true in their options will have the setting silently accepted but completely ignored — the strict trace checking won't activate.

Additional Locations (1)
Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant