ci: Remove secrets: inherit from changelog-preview workflow - #2177
Merged
oioki merged 2 commits intoAug 4, 2026
Merged
Conversation
The reusable getsentry/craft changelog-preview.yml workflow only uses the auto-provisioned GITHUB_TOKEN and doesn't declare any workflow_call secrets. Inheriting all repository secrets into it violates least privilege and isn't needed to make the workflow function. Refs VULN-2346 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
changelog-preview.yml is disabled_manually on GitHub and unused. Rather than fixing its secrets: inherit usage, remove the workflow entirely, consistent with how other getsentry repos are dropping this disabled workflow. Refs VULN-2346 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
BYK
approved these changes
Aug 4, 2026
oioki
deleted the
alextarasov/vuln-2346-improper-authorization-vulnerability-in-getsentrysentry-php
branch
August 4, 2026 20:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
changelog-preview.ymlusedsecrets: inheritwhen calling the reusablegetsentry/craft/.github/workflows/changelog-preview.yml, exposing every repository secret to the called workflow.disabled_manuallyon GitHub and unused — removed it entirely instead of fixing its secret handling, consistent with how other getsentry repos are dropping this disabled workflow.Test plan
Changelog Previewworkflow state isdisabled_manuallyFixes VULN-2346
🤖 Generated with Claude Code