fix: remove dependency on AnalyticsSessionInfo#2625
Merged
bitsandfoxes merged 7 commits intomainfrom Apr 2, 2026
Merged
Conversation
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛
Internal Changes 🔧Deps
Other
Other
🤖 This preview updates automatically when you update the PR. |
mujacica
approved these changes
Apr 2, 2026
PopulateUser was falling back to options.InstallationId which caused User.Id to be set on the scope before the .NET SDK Enricher runs. This made HasUser() return true, preventing IsEnvironmentUser from setting the Username when SendDefaultPii is enabled. The Enricher already sets User.Id from InstallationId after the HasUser() check, so the ID is still always present on every event.
d038eba to
166abe9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2622
We first added the reliance on
AnalyticsSessionInfowhen building the first version of mobile native support to be able to tie the resulting issues together. With the growing platform support we kept hitting restriction and limitations (i.e. cannot use on consoles, causes crashes due to implicitly writing to disk without asking).Additionally, the
UnityEngine.Analytics.AnalyticsSessionInfo.userIdAPI is part of a legacy system being phased out. Since we already fetch the native user ID on most platforms (mobile) we can clean this up, and move on, relying on our own mechanisms instead.