fix(code-review): Add easy flippable code review beta freeze#106477
Closed
suejung-sentry wants to merge 3 commits intomasterfrom
Closed
fix(code-review): Add easy flippable code review beta freeze#106477suejung-sentry wants to merge 3 commits intomasterfrom
suejung-sentry wants to merge 3 commits intomasterfrom
Conversation
suejung-sentry
commented
Jan 16, 2026
| if options.get("seer.code-review.is-beta-open"): | ||
| return has_beta_flag or bool(has_legacy_opt_in) | ||
|
|
||
| return has_beta_flag |
Contributor
Author
There was a problem hiding this comment.
same logic here. This flow is the live one that goes through sentry instead of overwatch
suejung-sentry
commented
Jan 16, 2026
| "sentry:enable_pr_review_test_generation", | ||
| False, | ||
|
|
||
| if options.get("seer.code-review.is-beta-signup-open"): |
Contributor
Author
There was a problem hiding this comment.
while the beta is open we have a "dynamic" list that allows code review for anyone who has the toggle on.
once the beta is closed, we only read the static list (code-review-beta)
Note this flow is not live right now (it's the overwatch flow) but updating just in case
Member
|
All places that read |
Contributor
Author
|
closed in favor of other strategy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plug into a flag we can flip at the moment when the code review beta list is frozen