Skip to content

fix(code-review): Add easy flippable code review beta freeze#106477

Closed
suejung-sentry wants to merge 3 commits intomasterfrom
sshin/fix-code-review-freeze
Closed

fix(code-review): Add easy flippable code review beta freeze#106477
suejung-sentry wants to merge 3 commits intomasterfrom
sshin/fix-code-review-freeze

Conversation

@suejung-sentry
Copy link
Copy Markdown
Contributor

Plug into a flag we can flip at the moment when the code review beta list is frozen

@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 16, 2026
if options.get("seer.code-review.is-beta-open"):
return has_beta_flag or bool(has_legacy_opt_in)

return has_beta_flag
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same logic here. This flow is the live one that goes through sentry instead of overwatch

"sentry:enable_pr_review_test_generation",
False,

if options.get("seer.code-review.is-beta-signup-open"):
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while the beta is open we have a "dynamic" list that allows code review for anyone who has the toggle on.

once the beta is closed, we only read the static list (code-review-beta)

Note this flow is not live right now (it's the overwatch flow) but updating just in case

@suejung-sentry suejung-sentry marked this pull request as ready for review January 16, 2026 22:22
@suejung-sentry suejung-sentry requested a review from a team as a code owner January 16, 2026 22:22
@ryan953
Copy link
Copy Markdown
Member

ryan953 commented Jan 16, 2026

All places that read code-review-beta would need to have the same behavior i believe. So there should be a similar PR to address callsites in the frontend.

Copy link
Copy Markdown
Member

@armenzg armenzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@suejung-sentry
Copy link
Copy Markdown
Contributor Author

closed in favor of other strategy

@suejung-sentry suejung-sentry deleted the sshin/fix-code-review-freeze branch January 20, 2026 21:15
@suejung-sentry suejung-sentry self-assigned this Jan 29, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants