feat(search): Add team: filter for issues by project ownership #106501
+136
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Adds a new `team:` search filter that allows filtering issues by the team that owns the project. This addresses GitHub issue getsentry#45367. Usage: - `team:data-engineering` - Issues from projects owned by data-engineering - `team:#data-engineering` - Same (# prefix supported for consistency) - `!team:data-engineering` - Issues NOT from data-engineering's projects - `team:[team1,team2]` - Issues from projects owned by either team Changes: - Add team key mapping and convert_team_value() in issue_search.py - Add team_filter() function and condition in backend.py - Add 'team' to NO_CONVERSION_FIELDS to skip Snuba conversion - Add comprehensive tests for team filter functionality Security: - Filter teams through projectteam relationship to prevent IDOR - Users can only filter by teams associated with their searched projects Co-Authored-By: Claude Opus 4.5 <[email protected]>
mishamo
force-pushed
the
feat/team-issue-filter
branch
from
5aba036 to
81d8ffc
Compare
Author
|
bugbot review |
Author
|
@sentry review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Author
|
Is there anything else I have to do in the PR process here? (I can't find any docs). Or is this just waiting for a maintainer to take a look? |
Contributor
you're all good, i'll take a look. |
cvxluo
added
the
Trigger: getsentry tests
Member
|
this likely would need to take into account the org open membership settings |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new
team:search filter that allows filtering issues by the team that owns the project. This addresses #45367.Usage:
team:data-engineering- Issues from projects owned by data-engineeringteam:#data-engineering- Same (# prefix supported for consistency with other team references)!team:data-engineering- Issues NOT from data-engineering's projectsteam:[team1,team2]- Issues from projects owned by either teamChanges
src/sentry/issues/issue_search.py:teamkey mappingconvert_team_value()converter that validates teams throughprojectteamrelationship (prevents IDOR by ensuring users can only filter by teams associated with their searched projects)src/sentry/search/snuba/backend.py:team_filter()functionteamcondition to queryset buildertests/snuba/search/test_backend.py:test_team_filter- Basic filtering with/without # prefixtest_team_filter_negation-!team:exclusiontest_team_filter_invalid_team- Error handling for non-existent teamstest_team_filter_multiple_teams-team:[t1,t2]syntaxtest_team_filter_team_not_in_searched_projects- Security test for IDOR preventionTest plan
#prefix works for consistency with other team references!team:) excludes issues from team's projectsInvalidSearchQuery🤖 Generated with Claude Code