test(ui): Remove unnecessary console error spies - #124865
Merged
Merged
Conversation
Fix missing request mocks, async test updates, invalid table markup, and controlled input warnings. Keep spies scoped to expected errors. Co-Authored-By: Codex <noreply@openai.com>
github-actions
Bot
added
the
Scope: Frontend
scttcper
marked this pull request as ready for review
September 18, 2026 16:16
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3abfc11. Configure here.
| <Table.Body> | ||
| <LoadingRenderer /> | ||
| </Table.Body> | ||
| </Table> |
Contributor
There was a problem hiding this comment.
Loading table missing column tracks
Medium Severity
The no-replay placeholder now wraps LoadingRenderer in Table without a columns prop. Table builds an empty grid-template-columns value, and DataTable.Status places its cell with grid-column: 1 / -1, so the loading row can collapse to zero width and hide the spinner.
Reviewed by Cursor Bugbot for commit 3abfc11. Configure here.
ryan953
approved these changes
Sep 18, 2026
Restore the replay loading markup and scope its existing console error suppression to the placeholder test. Co-Authored-By: Codex <noreply@openai.com>
Keep Emotion DOM prop validation when excluding overflow so styling props stay off the DOM and the as prop still selects the element. Co-Authored-By: Codex <noreply@openai.com>
nsdeschenes
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove 22 unnecessary console.error spies and scope four suite-wide spies to the tests that need them. The broad suppression was hiding missing API mocks, async updates outside act, an uncontrolled sampling input, and a boolean prop leaking onto the DOM.
Fix those warnings so unexpected console errors fail the affected tests again. Keep the spies for expected error reporting, the existing replay loading markup warning, and the React Aria focus issues in the search and arithmetic builders that need a larger fix.