Skip to content

fix(logs): Stop repeated timeseries requests during auto-refresh - #124884

Merged
nsdeschenes merged 2 commits into
masterfrom
nd/fix-logs-autorefresh-loop
Sep 18, 2026
Merged

nsdeschenes merged 2 commits into
masterfrom
nd/fix-logs-autorefresh-loop

Conversation

@nsdeschenes

@nsdeschenes nsdeschenes commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Enabling auto-refresh on the logs page could continuously request events-timeseries, even with the export modal closed. The export row-count estimate recomputed its ingestion cutoff from Date.now() on each render, changing the query key as streaming updates rerendered the page.

Pass the chart's existing ingestion cutoff into the export estimate so its request stays stable and matching chart requests can deduplicate.

Reuse the chart ingestion cutoff for the export row estimate so timed rerenders
do not create new events-timeseries query keys.
Verify timed rerenders retain one request and a changed chart cutoff triggers
a new estimate request.
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Sep 18, 2026
@nsdeschenes
nsdeschenes marked this pull request as ready for review September 18, 2026 12:50
@nsdeschenes
nsdeschenes requested a review from a team as a code owner September 18, 2026 12:50
Comment thread static/app/views/explore/logs/logsTab.tsx

@mjq mjq left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

@nsdeschenes
nsdeschenes merged commit d4f7240 into master Sep 18, 2026
76 checks passed
@nsdeschenes
nsdeschenes deleted the nd/fix-logs-autorefresh-loop branch September 18, 2026 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants