Repository navigation
ref(issues): Use scraps primitives in custom archive duration modal - #131027
Draft
sentry-junior[bot] wants to merge 2 commits into
Draft
sentry-junior[bot] wants to merge 2 commits into
sentry-junior[bot] wants to merge 2 commits into
Conversation
Replace the legacy form-horizontal, control-group, nav-header, and form-control classes in the archive-until modal with Stack and Text primitives, and give each input a label. Delete the now-unused .form-horizontal and .nav-header LESS rules. Co-Authored-By: Malachi Willey <malachi.willey@sentry.io>
github-actions
Bot
added
the
Scope: Frontend
…gnore-duration-modal # Conflicts: # static/css/shared-components.css # static/css/shared/forms.css
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Archive this issue until…" modal (Archive › For… › Custom) no longer uses the legacy
form-horizontal,control-group,nav-header, andform-controlclasses. The layout is nowStack, and the Date / Time (UTC) headings areText as="label"elements tied to their inputs withhtmlFor, so the inputs have accessible names. Ids, refs,required, and the submit logic are unchanged. A new spec covers the label wiring, a valid archive, and the past-date warning.The
.form-horizontaland.nav-headerrules are deleted fromstatic/less. This modal was their only user: nothing instatic/app,static/gsApp,static/gsAdmin,static/packages, sentry'ssrc/templates and Python, getsentry, or the crispy-forms bootstrap3 templates references them. The only otherform-horizontalhits are DRF's browsable API templates. Sentry doesn't enable that renderer (it only usesJSONRenderer), and those templates ship their own bootstrap CSS anyway..control-groupstays for now becausestatic/gsAdmin/components/provisionSubscriptionAction.tsxstill uses it. That file is being converted in a separate PR, and the rule can be deleted once both PRs land..m-b-1and.form-controlare still used by Django templates and stay as well.Visual change: the labels now use the
muted(secondary) text color instead of the lighter legacy gray, and the modal is about 4px shorter because the oldm-b-1bottom margin is gone.Screenshots
I took before (
master) and after (this branch) screenshots of Issue details › Archive › For… › Custom at the same framing on a local devserver, and pixel-diffed them: they differ only in the label color and the ~4px height change described above. They aren't attached yet because uploading them withgh --attachneeds a GitHub user authorization that this session couldn't start.via malachi.
--
View Session [Sentry]