Repository navigation
ref(admin-billing-platform): Drop unmatched orgs table from invoice comparison - #131037
armcknight wants to merge 2 commits into
Conversation
… comparison The bottom table of the _admin invoice comparison listed orgs with a legacy invoice but no MIGRATED_TO_BILLING_PLATFORM flag. That is not a parity signal, only a list of who has not migrated yet, and the backend only ever filled it with `legacy_only` rows. The one-sided case that matters, a migrated org with invoices on one side only, already appears in the main table as `legacy_only`/`platform_only` with infinite drift. Remove the panel, its row types, the `unmatched_page` URL param and the page-fix logic for it. The endpoint keeps sending `unmatched` until the getsentry side drops it, so this has to land first. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Frontend
…parison The table now lists only the migrated orgs whose two sides disagree (mismatch, legacy_only, platform_only). Matching orgs still feed the summary, so the >1% diff denominator moves to the new summary.compared_count; row_count now counts the listed rows and drives the paginator. Until the getsentry side lands, compared_count renders as the existing missing-value dash. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f896676. Configure here.
| <PanelHeader> | ||
| Rows (sorted by |delta|, biggest first) — queried {data.summary.queried_at} | ||
| Mismatching orgs (sorted by |delta|, biggest first) — queried{' '} | ||
| {data.summary.queried_at} |
There was a problem hiding this comment.
Empty table misreports matching orgs
Medium Severity
Matching orgs now count in the summary and are omitted from table rows, so an empty list can mean every compared org agreed. The empty copy still says there are no invoices on either side, which is wrong on the all-match path and can look like a failed query even when compared_count is non-zero.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit f896676. Configure here.
As we are now migrating most of our remaining orgs, this table is usefulness has run its course.