Repository navigation
Conversation
The shared code mapping order puts user-made mappings first, so a user-made catch-all mapping claimed every frame. Take the matching mapping with the longest stack root. Refs CW-2261
github-actions
Bot
added
the
Scope: Backend
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the Seer token-based billing work. Token-billed orgs don't pick repos in Seer settings, Seer just uses whatever repos are linked to the project.
Follow-up to #130856. For Autofix we put the repos that match the event's stack frames first, so the 8-repo limit doesn't cut them. The match took the first code mapping in the shared order, and that order puts user-made mappings first. A user-made mapping with an empty stack root matches every frame, so it always won and the repo the frame really came from was never found.
About 30% of projects with more than 8 linked repos have a mapping like that, so this takes the matching mapping with the longest stack root instead. Equal roots still follow the shared order.
Refs CW-2261