Open
Conversation
Change the store to allow fetching multiple pending tasks at once. This is the first step towards being able to batch fetch tasks from the worker. This adds a `get_pending_activations` function, and points the existing function to call that function with a limit of 1. In the future new endpoints can leverage the pending activations function directly. That function accepts the namespaces that are being requested, and the number of pending tasks that can be returned.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #261 +/- ##
==========================================
+ Coverage 83.35% 83.79% +0.44%
==========================================
Files 19 20 +1
Lines 3568 3697 +129
==========================================
+ Hits 2974 3098 +124
- Misses 594 599 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
markstory
reviewed
Mar 19, 2025
Member
markstory
left a comment
markstory
left a comment
There was a problem hiding this comment.
Looks good to me. I don't think we'll need a batch API in the immediate future. We could hold onto this until the need for batch get is more evident though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the store to allow fetching multiple pending tasks at once. This is the first step towards being able to batch fetch tasks from the worker.
This adds a
get_pending_activationsfunction, and points the existing function to call that function with a limit of 1. In the future new endpoints can leverage the pending activations function directly. That function accepts the namespaces that are being requested, and the number of pending tasks that can be returned.