Open
Conversation
The main motivation for this change was unnecessary double point in the icon path. The top point of the right corner of the icon are in fact two separate points. I’ve used Inkscape’s ‘Join selected nodes’ function to merge them. I’ve then rounded coordinates in the path to two decimal points (again using Inkscape) and finally using a simple regex eliminate unnecessary spaces in the `d` attribute. Working on that I've noticed that the clip paths don’t actually do anything: the paths do not go over the clip paths. I’ve thus removed the clip paths. The styles for the path were over-specified. `fill-opacity: 1`, `fill-rule: nonzero` and `stroke: none` are all initial values of the properties, so I’ve stripped them out. Finally, in the Logo images, the `width` attribute was specified without a unit. To match the `height` and the Icon images, I’ve added `pt` unit. Signed-off-by: Michal Nazarewicz <mina86@mina86.com>
Member
|
Seems fine to me, but also these things haven't been a problem in the past 14 years so... 🤷🏼. I'll leave it to the current maintainers to decide. |
Author
|
I’ve only noticed because importing it to FontForge results in an ‘Open Contour’ warning. |
Member
|
Honestly, I don't quite see the point of this improvement... Why change something that served us well for so long? "Don't fix that which ain't broken..." |
Author
|
Depends on what you consider ‘broken’. It does result in Open Contour error when importing the file in FontForge. While FF can deal with it, I figured might just as well fix it at the source. But yes, I agree that it’s not a big deal. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main motivation for this change was unnecessary double point in the icon path. The top point of the right corner of the icon are in fact two separate points. I’ve used Inkscape’s ‘Join selected nodes’ function to merge them. I’ve then rounded coordinates in the path to two decimal points (again using Inkscape) and finally using a simple regex eliminate unnecessary spaces in the
dattribute.Working on that I've noticed that the clip paths don’t actually do anything: the paths do not go over the clip paths. I’ve thus removed the clip paths.
The styles for the path were over-specified.
fill-opacity: 1,fill-rule: nonzeroandstroke: noneare all initial values of the properties, so I’ve stripped them out.Finally, in the Logo images, the
widthattribute was specified without a unit. To match theheightand the Icon images, I’ve addedptunit.Cc: @jasonlong