feat(logging): add log_class parameter to runner log files configuration#5036
feat(logging): add log_class parameter to runner log files configuration#5036Brend-Smits wants to merge 2 commits intomainfrom
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
|
@Brend-Smits did you run a quick check on the multi-runner as well default example? Please can you also update all other log groups managed by the module? See https://github.com/github-aws-runners/terraform-aws-github-runner/search?q=repo%3Agithub-aws-runners%2Fterraform-aws-github-runner%20path%3A*.tf%20resource%20%22aws_cloudwatch_log_group%22&type=code |
Yes I tested this with the multi runner example and it works as advertised. As expected, when you change the log class for existing log groups, it forces a replacement on the whole group. I also updated it for all the other modules. |
bc49180 to
c70da8b
Compare
Extends the log_class parameter to all CloudWatch log groups managed by the module, allowing users to set INFREQUENT_ACCESS class to reduce costs. Log groups updated: - runner-binaries-syncer (syncer) - ami-housekeeper - runners (scale-down, scale-up, ssm-housekeeper) - runners/pool - webhook/direct - webhook/eventbridge (webhook, dispatcher) - lambda module (shared) - termination-watcher - multi-runner (passthrough to all submodules) Defaults to STANDARD for backward compatibility.
c70da8b to
5820b11
Compare
This pull request updates the logging configuration by introducing support for the
log_classproperty, allowing log groups to be created with either theSTANDARDorINFREQUENT_ACCESSclass. The change is applied throughout the configuration to ensure log groups and log files can specify their class, defaulting toSTANDARDif not set.Logging configuration enhancements:
log_classproperty (defaulting to"STANDARD") to therunner_log_filesandmulti_runner_configvariables invariables.tf,modules/runners/variables.tf, andmodules/multi-runner/variables.tfto allow specifying the log group class. [1] [2] [3]modules/runners/logging.tfto include thelog_classproperty for each log file, defaulting to"STANDARD".modules/runners/logging.tfto use the specifiedlog_classwhen creating log groups, and refactored the logic to group log files by both name and class.Documentation improvements:
runner_log_filesvariable to document the newlog_classproperty and its valid values.