Skip to content

Conversation

@GuySartorelli
Copy link

@GuySartorelli GuySartorelli commented Nov 20, 2025

Adding the Silverstripe Templating language. See https://docs.silverstripe.org/en/6/developer_guides/templates/syntax/ for in-depth information about this templating language.

Description

Checklist:

@GuySartorelli GuySartorelli requested a review from a team as a code owner November 20, 2025 03:29
@patricknelson
Copy link

Thanks for submitting this @GuySartorelli 🎉

@GuySartorelli GuySartorelli force-pushed the pulls/main/add-ss-templates branch from 293849b to fc47e2b Compare November 20, 2025 04:08
@patricknelson
Copy link

patricknelson commented Nov 20, 2025

For the record: Going on Silverstripe's CMS style guide, we're thinking the bright blue #005AE1 makes more sense over the dark blue #0049A3 given how small the design element is in the GitHub UI, so it'll stand out a little bit more and be more distinct from the color PHP is using (#4F5D95). That's important since this will likely always be shown adjacent to PHP (given Silverstripe is a PHP based CMS and framework).

image

Coincidentally, this "bright blue" isn't too far off from the existing color already being associated with *.ss files via Scheme (#1e4aec), so the most visible change here will mainly just be the file type being displayed, i.e. "Silverstripe Templates.

Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need the cached license file that would have been created when you ran script/add-grammar.

@GuySartorelli
Copy link
Author

GuySartorelli commented Nov 20, 2025

I've committed all of the changes (just did a straight git add . && git commit) - that script must not have created a cached license file. Can you please provide me with instructions to either find out what went wrong, or else to create the file another way?

@lildude
Copy link
Member

lildude commented Nov 20, 2025

This is the command that should have run:

bundle exec licensed cache -c vendor/licenses/config.yml

You can run it manually but you might want to check why it might have failed before it got here. Maybe there's a problem with the grammar? (An error should have been reported)

@patricknelson
Copy link

patricknelson commented Nov 20, 2025

Not sure about the automations, but:

Does that help @lildude? If so, then maybe the file you're looking for can be generated manually instead. If so, maybe next steps are:

  1. @GuySartorelli look up the details of the licenses used for the samples and
  2. @lildude let us know:
    a. If that license can be manually done.
    b. Where it'd be, e.g. at vendor/licenses/git_submodule/language-[NAME].dep.yml? Presumably similar to this recently merged request (Hurl)? https://github.com/github-linguist/linguist/pull/7627/files#diff-496746ca94fd0d61db41d5c9ce50a86a0205b451e612527664a3d9c7fc9afda0

Edit: Just realized you replied shortly before my comment, but will leave it up in case there's a pathway for manual completion as well.

@GuySartorelli
Copy link
Author

GuySartorelli commented Nov 20, 2025

@patricknelson The license being discussed is specifically for the grammar. Sample licenses and sources are mentioned in the files themselves and in the PR description. I'm sure if more needs to be done in that respect we'll be told what to do 👍

@GuySartorelli
Copy link
Author

Running bundle exec licensed cache -c vendor/licenses/config.yml gives this output:

Caching dependency records for app

But no files were changed.

you might want to check why it might have failed before it got here. Maybe there's a problem with the grammar? (An error should have been reported)

No errors were reported this time nor when I ran script/add-grammar initially. In fact the output I just got from running the licensed cache command was part of the output I got when I ran script/add-grammar.

If you can provide me with debug steps I'll gladly look more into it - or alternatively if there's a more manual way to cache the license I'll happily do that too if you can tell me how.

@lildude
Copy link
Member

lildude commented Dec 12, 2025

Worked for me (I re-ran the script/add-grammar command) so I've added the cached file for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants