[GHSA-7g5w-pq96-8c5w] flash-attention contains an insecure deserialization vulnerability in its checkpoint loading mechanism#7803
Open
warsang wants to merge 1 commit into
Conversation
github-actions
Bot
changed the base branch from
main
to
warsang/advisory-improvement-7803
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
Comments
The original advisory covers only training/src/utils/checkpoint.py and training/src/eval.py, both in the source repo. The same unsafe-deserialization pattern (CWE-502) is present at three additional sites in the current tree, including flash_attn/utils/pretrained.py and flash_attn/models/llama.py, which are installed as part of the flash_attn wheel and therefore reachable by every package consumer, not just users running the training scripts. Also proposing a CWE correction (502 vs. 94) and a CVSS revision to reflect arbitrary RCE impact.