Rust: Take trait visibility into account when resolving paths and methods#20321
Merged
paldepind merged 2 commits intogithub:mainfrom Sep 2, 2025
Merged
Rust: Take trait visibility into account when resolving paths and methods#20321paldepind merged 2 commits intogithub:mainfrom
paldepind merged 2 commits intogithub:mainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Rust a trait method can only be invoked if the trait is visible/in scope, but currently all traits are treated as globally visible.
With this PR, for a path
Type::methodwe only considermethodmethods on traits that are visible. Similarly, for method callsfoo.bar(...)we only considerbarmethods on traits that are visible.This PR is motived by a type explosion in Deno that is magnified by #20133. Accounting for visible traits in #20133 in the same way as in this PR should also reduce false positives for blanket implementations.
DCA shows:
multipleCallTargetsviolations.databendwe loose targets for 1020 calls and path resolution inconsistencies is down 5191. One plausible interpretation is that there where 5191 calls where we found the correct target plus a wrong one and 1020 calls where we only found a wrong one.