Remove [[ link syntax from C# XSS sink#22095
Open
d10c wants to merge 1 commit into
Open
Conversation
Remove the makeUrl predicate and the [[""|""]]] link syntax from AspxCodeSink.explanation(), replacing with plain text. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes legacy, undocumented [[ ... | ... ]] link syntax from the C# XSS sink explanation used for ASPX inline-member sinks, simplifying the message to plain text and deleting the now-unused URL-construction helper.
Changes:
- Deleted the private
makeUrl(Location l)predicate that generatedfile://...URLs for the legacy link syntax. - Updated
AspxCodeSink.explanation()to return a plain-text explanation string without[[ ... ]].
Show a summary per file
| File | Description |
|---|---|
| csharp/ql/lib/semmle/code/csharp/security/dataflow/XSSSinks.qll | Removes legacy [[ link formatting from the ASPX inline sink explanation and deletes the helper predicate that supported it. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Low
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the
makeUrl()private predicate and[[usage fromAspxCodeSink.explanation()inXSSSinks.qll, replacing it with plain text. This syntax is legacy, undocumented, and about to be removed.