Run SDK tests on push to main branch#390
Merged
SteveSandersonMS merged 1 commit intomainfrom Feb 6, 2026
Merged
Conversation
e4e3f9b to
d406d90
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds push triggers to all four SDK test workflows (Python, Node.js, Go, and .NET) to ensure tests run automatically after PRs are merged to the main branch. Previously, these workflows only ran on pull requests, meaning the main branch didn't get continuous testing after merges.
Changes:
- Added push triggers for the main branch to Python, Node.js, Go, and .NET SDK test workflows
- Configured path filters for push triggers to match relevant SDK and test directories
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/python-sdk-tests.yml | Added push trigger for main branch with path filters for Python SDK |
| .github/workflows/nodejs-sdk-tests.yml | Added push trigger for main branch with path filters for Node.js SDK |
| .github/workflows/go-sdk-tests.yml | Added push trigger for main branch with path filters for Go SDK |
| .github/workflows/dotnet-sdk-tests.yml | Added push trigger for main branch with path filters for .NET SDK |
Comments suppressed due to low confidence (3)
.github/workflows/python-sdk-tests.yml:17
- The path filters for the push trigger are incomplete compared to the pull_request trigger. The pull_request trigger includes additional exclusions for .editorconfig and image files (png, jpg, jpeg, gif, svg) that are missing from the push trigger. These path filters should be identical to ensure consistent behavior whether tests run on a pull request or after merging to main.
pull_request:
paths:
- 'python/**'
- 'test/**'
- 'nodejs/package.json'
- '.github/workflows/python-sdk-tests.yml'
- '!**/*.md'
- '!**/LICENSE*'
.github/workflows/nodejs-sdk-tests.yml:17
- The path filters for the push trigger are incomplete compared to the pull_request trigger. The pull_request trigger includes additional exclusions for image files (png, jpg, jpeg, gif, svg) that are missing from the push trigger. These path filters should be identical to ensure consistent behavior whether tests run on a pull request or after merging to main.
pull_request:
paths:
- 'nodejs/**'
- 'test/**'
- '.github/workflows/nodejs-sdk-tests.yml'
- '!**/*.md'
- '!**/LICENSE*'
- '!**/.gitignore'
.github/workflows/dotnet-sdk-tests.yml:17
- The path filters for the push trigger are incomplete compared to the pull_request trigger. The pull_request trigger includes additional exclusions for jpeg, gif, and svg image files that are missing from the push trigger. These path filters should be identical to ensure consistent behavior whether tests run on a pull request or after merging to main.
pull_request:
paths:
- 'dotnet/**'
- 'test/**'
- 'nodejs/package.json'
- '.github/workflows/dotnet-sdk-tests.yml'
- '!**/*.md'
- '!**/LICENSE*'
- '!**/.gitignore'
- '!**/.editorconfig'
- '!**/*.png'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All SDK test workflows were only running on pull requests, not on merges to main. This adds \push\ triggers for the \main\ branch so tests run after PRs are merged.