refactor: remove legacy bounded execution in favor of MCP enclaves - #6994
Conversation
|
✅ Copilot review passed with no inline comments. @lpcox Add the |
|
@copilot merge main |
Merged main in ca85a36. Resolved modify/delete conflicts on |
ca85a36 to
f55df81
Compare
|
📡 Smoke OTel Tracing completed. All tracing scenarios validated. ✅ |
|
✅ Smoke Copilot BYOK completed. Copilot BYOK mode operational. 🔓 |
|
✅ Smoke Claude passed |
|
📰 VERDICT: Smoke Docker Sbx has concluded. All systems operational. This is a developing story. 🎤 |
|
✅ Build Test Suite completed successfully! |
|
❌ Smoke Copilot BYOK AOAI (Entra) reports failed. AOAI BYOK (Entra) mode investigation needed... |
|
🛡️ Smoke Copilot Network Isolation confirmed the egress allowlist is enforced. ✅ |
|
✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟 |
|
❌ Security Guard failed. Please review the logs for details. |
|
❌ Smoke Copilot BYOK AOAI (api-key) reports failed. AOAI BYOK (api-key) mode investigation needed... |
|
❌ Contribution Check failed. Please review the logs for details. |
|
Chroot tests passed! Smoke Chroot - All security and functionality tests succeeded. |
|
✅ Smoke Gemini completed. All facets verified. 💎 Smoke test: connectivity check |
|
🔌 Smoke Services — All services reachable! ✅ |
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤 |
|
❌ Security Guard failed. Please review the logs for details. |
|
❌ Contribution Check failed. Please review the logs for details. |
|
📰 DEVELOPING STORY: Smoke Copilot reports failed to deliver outputs. Our correspondents are investigating the incident... |
|
✅ Smoke Gemini completed. All facets verified. 💎 Smoke test completed with partial success (File/Bash ✅, MCP/Net ❌). Results posted to PR 6994. |
|
🌑 The shadows whisper... Smoke Codex failed. The oracle requires further meditation... |
|
🔌 Smoke Services — All services reachable! ✅ |
|
🛡️ Smoke Copilot Network Isolation reports failed to deliver outputs while checking network isolation. Investigate the egress model. |
|
Build Test Failed Build Test Suite - See logs for details |
|
Chroot tests passed! Smoke Chroot - All security and functionality tests succeeded. |
|
📰 DEVELOPING STORY: Smoke Docker Sbx reports failed to deliver outputs. Our correspondents are investigating the incident... |
|
❌ Smoke Copilot BYOK AOAI (Entra) reports failed to deliver outputs. AOAI BYOK (Entra) mode investigation needed... |
Smoke Test: Claude Engine Validation
Overall result: PASS
|
Smoke Test: Copilot BYOK (Direct) Mode✅ GitHub MCP connectivity (PR fetch works) Status: PASS — Running in direct BYOK mode via Recent PRs: #7027 (v0.86.0 upgrade), #6996 (api-proxy alias fix)
|
|
Smoke Test: Copilot Engine — @lpcox
Overall: PASS
|
|
EGRESS_RESULT allow=pass deny=pass ✅ Allowed domain (api.github.com): reachable, HTTP 200 Overall: PASS cc @lpcox Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "example.com"See Network Configuration for more information.
|
Smoke Test: API Proxy OTEL Tracing
Result: All checked scenarios passed.
|
|
Smoke test:
Running in direct BYOK mode (COPILOT_PROVIDER_API_KEY + COPILOT_PROVIDER_BASE_URL) via api-proxy → Azure OpenAI (Foundry, o4-mini-aw) @lpcox Overall: PASS
|
Smoke Test Results: GitHub Actions Services Connectivity
Overall: FAIL —
|
Smoke Test: Gemini Engine Validation
Overall status: FAIL
|
Chroot Version Comparison Results
Overall: FAILED — Node.js version mismatch between host (
|
🏗️ Build Test Suite Results
Overall: 8/8 ecosystems passed — PASS Notes:
|
|
chore: upgrade gh-aw to v0.86.0 pre-release and recompile workflows: ✅
|
|
Smoke Test: Docker Sbx Validation
Overall: PASS PRs checked: #7027 "chore: upgrade gh-aw to v0.86.0 pre-release and recompile workflows", #6996 "fix(api-proxy): stop alias fallback picking arbitrary models" cc @lpcox
|
Stack
Final layer 5, targeting
lpcox-enclave-mcpg-integration(#6992).Depends on:
Summary
enclave_run_scriptandenclave_run_agent, conditionally by enabled executor, with primary-agent access exclusively through mcpg.enclave-script,enclave-agent, andenclave-mcp-serverimages fromcontainers/enclave/Dockerfile.Rollout ordering
Do not enable this layer until github/gh-aw#50920's compiler contract and github/gh-aw-mcpg#10784's late backend rediscovery are available. The latter requires MCP Gateway spec 1.15.0 and the first gh-aw-mcpg release after v0.4.8 containing it. Firewall readiness continues to retry
503 backend_unavailablewithinAWF_ENCLAVE_MCP_READINESS_TIMEOUT_MS; that behavior is inherited from #6992 rather than duplicated here.Validation
Passed locally:
Environment-blocked locally:
npm cicannot fetchtypescript-eslint@8.66.0(ENOTCONN; Microsoft mirror also lacks the tarball), so TypeScript type-check/build, Jest suites, and changed-file ESLint could not run.@github/copilot@1.0.34from npm in this environment.runsc, so the gVisor smoke remains CI-only.Intentional residual terminology
The removed names remain only in the explicit migration tables in
docs/awf-config-spec.mdanddocs/enclaves-architecture.md, mapping old concepts toenclave_run_scriptandenclave_run_agent. There are no active code, config, workflow, image, service, or wrapper references.